-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2E: Prepare for emulator based on protocol #1656
Conversation
/test metal3-bmo-e2e-test-pull |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit on the log messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In CI we currently specify the emulator to use (sushy-tools or VBMC) and can in addition specify the protocol for sushy-tools. This change is a preparation to switch to specifying the protocol instead and picking the emulator based on it. Signed-off-by: Lennart Jern <[email protected]>
cce40dc
to
d5f3367
Compare
/test metal3-bmo-e2e-test-pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/override test-centos-e2e-integration-main |
@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
In CI we currently specify the emulator to use (sushy-tools or VBMC) and can in addition specify the protocol for sushy-tools. This change is a preparation to switch to specifying the protocol instead and picking the emulator based on it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #