Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Prepare for emulator based on protocol #1656

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Apr 8, 2024

What this PR does / why we need it:

In CI we currently specify the emulator to use (sushy-tools or VBMC) and can in addition specify the protocol for sushy-tools. This change is a preparation to switch to specifying the protocol instead and picking the emulator based on it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 8, 2024

/test metal3-bmo-e2e-test-pull

@mquhuy
Copy link
Member

mquhuy commented Apr 8, 2024

lgtm

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on the log messages.

hack/ci-e2e.sh Outdated Show resolved Hide resolved
hack/ci-e2e.sh Outdated Show resolved Hide resolved
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
In CI we currently specify the emulator to use (sushy-tools or VBMC)
and can in addition specify the protocol for sushy-tools. This change is
a preparation to switch to specifying the protocol instead and picking
the emulator based on it.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-bmc-protocol branch from cce40dc to d5f3367 Compare April 9, 2024 06:19
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90 lentzi90 requested a review from tuminoid April 9, 2024 06:39
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 2921a15 into metal3-io:main Apr 9, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/e2e-bmc-protocol branch April 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants