Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Cleanup emulator variable #1661

Merged

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Apr 9, 2024

What this PR does / why we need it:

We are now specifying the BMC protocol directly and do not need to expose the emulator variable. The emulator will be picked based on the protocol.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/test metal3-bmo-e2e-test-pull

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hack/ci-e2e.sh Outdated Show resolved Hide resolved
We are now specifying the BMC protocol directly and do not need to
expose the emulator variable. The emulator will be picked based on
the protocol.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-cleanup-emulator-variable branch from 9eaa4cf to d054caa Compare April 9, 2024 09:04
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Apr 9, 2024

/cc @kashifest

@metal3-io-bot metal3-io-bot requested a review from kashifest April 9, 2024 10:41
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Much easier to understand now. Thanks for the cleanup

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@metal3-io-bot metal3-io-bot merged commit 15cf981 into metal3-io:main Apr 9, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/e2e-cleanup-emulator-variable branch April 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants