-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2E: Cleanup emulator variable #1661
🌱 E2E: Cleanup emulator variable #1661
Conversation
/test metal3-bmo-e2e-test-pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We are now specifying the BMC protocol directly and do not need to expose the emulator variable. The emulator will be picked based on the protocol. Signed-off-by: Lennart Jern <[email protected]>
9eaa4cf
to
d054caa
Compare
/test metal3-bmo-e2e-test-pull |
/override test-centos-e2e-integration-main |
@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @kashifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Much easier to understand now. Thanks for the cleanup
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We are now specifying the BMC protocol directly and do not need to expose the emulator variable. The emulator will be picked based on the protocol.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #