🌱 bump gophercloud/v2 to beta.3 + some commits to fix go.mod #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bumping gophercloud/v2 to v2.0.0-beta.2, it brought along a patch version to go directive in root go.mod. This set up a very strict golang requirement on BMO, which was made worse by the golang bump to v1.21.9. My PR in gophercloud fixed this issue, and we need to take in this v2.0.0-beta.3 + some commtis to include the fix, in order to not release BMO 0.6.0 with this requirement. In main, we should aim to bump to beta.4 as soon as it is released and preferably cherry-pick that to release-0.6 branch too. Signed-off-by: Tuomo Tanskanen <[email protected]>
metal3-io-bot
added
the
size/S
|
/test metal3-bmo-e2e-test-pull |
|
/cc @lentzi90 @adilGhaffarDev @dtantsur This needs to go in before BMO 0.6.0 is cut. PTAL. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
Good job fixing it in both places @tuminoid |
|
/test metal3-bmo-e2e-test-pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bumping gophercloud/v2 to v2.0.0-beta.2, it brought along a patch version to go directive in root go.mod. This set up a very strict golang requirement on BMO, which was made worse by the golang bump to v1.21.9.
My PR in gophercloud fixed this issue, and we need to take in this v2.0.0-beta.3 + some commits to include the fix, in order to not release BMO 0.6.0 with this strict golang requirement.
In main, we should aim to bump to beta.4 as soon as it is released and preferably cherry-pick that to release-0.6 branch too.