Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove capm3_e2e dependency from bmo E2E #1681

Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 17, 2024

BMO E2E is using some functions from CAPM3-E2E. This likely causes circular imports in the future.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-capm3-e2e-dependence branch from 1070124 to b03bee2 Compare April 17, 2024 18:54
@mquhuy mquhuy force-pushed the mquhuy/remove-capm3-e2e-dependence branch from b03bee2 to 620275b Compare April 17, 2024 19:00
@mquhuy mquhuy force-pushed the mquhuy/remove-capm3-e2e-dependence branch from 620275b to 3ec12f9 Compare April 17, 2024 19:02
@mquhuy
Copy link
Member Author

mquhuy commented Apr 17, 2024

/test metal3-bmo-e2e-test-pull
/test test-centos-e2e-integration-main

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good approach indeed.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@tuminoid
Copy link
Member

/test-centos-e2e-integration-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@metal3-io-bot metal3-io-bot merged commit d0378b4 into metal3-io:main Apr 18, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/remove-capm3-e2e-dependence branch April 18, 2024 06:24
@mquhuy
Copy link
Member Author

mquhuy commented Apr 18, 2024

/cherry-pick release-0.6

@metal3-io-bot
Copy link
Contributor

@mquhuy: new pull request created: #1682

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants