Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2E Upgrade: Add new tests for new BMO and Ironic releases #1692

Merged
merged 1 commit into from
May 6, 2024
Merged

🌱 E2E Upgrade: Add new tests for new BMO and Ironic releases #1692

merged 1 commit into from
May 6, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 23, 2024

This PR adds new upgrade tests from BMO release-0.6 and ironic release-24.1, also removes test from no-longer supported release-0.3

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-e2e-upgrade-from-release-0-6 branch from 7c43e50 to a802a47 Compare April 23, 2024 08:25
@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test dev-env-integration-test-centos-release-1-5
  • /test dev-env-integration-test-ubuntu-release-1-5
  • /test dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/test metal3-bmo-e2e-test-optional-pull

@mquhuy mquhuy force-pushed the mquhuy/add-e2e-upgrade-from-release-0-6 branch from a802a47 to b563240 Compare April 23, 2024 09:00
@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/test metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/test metal3-bmo-e2e-test-pull
/metal3-centos-e2e-integration-test-main

@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/test metal3-centos-e2e-integration-test-main

@mquhuy
Copy link
Member Author

mquhuy commented Apr 23, 2024

/retest

@mquhuy mquhuy requested a review from lentzi90 April 23, 2024 12:32
@lentzi90
Copy link
Member

Test failure looks like random network issues...
/test metal3-bmo-e2e-test-pull

lentzi90
lentzi90 reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@lentzi90
Copy link
Member

Let's also run the optional tests
/test metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented Apr 24, 2024

/test metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented May 6, 2024

/cc @kashifest @Rozzii @tuminoid @dtantsur @gklein

Rozzii
Rozzii approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 1b4fae4 into metal3-io:main May 6, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-e2e-upgrade-from-release-0-6 branch May 6, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Rozzii approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

@gklein gklein Awaiting requested review from gklein

@kashifest kashifest Awaiting requested review from kashifest

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @lentzi90 @Rozzii