Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add new go library to create new bmc and bmh #1767

Merged
merged 1 commit into from
Jul 8, 2024
Merged

🌱 Add new go library to create new bmc and bmh #1767

merged 1 commit into from
Jul 8, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jun 4, 2024 •
edited
Loading

Fixes #1560

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2024
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Jun 4, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-bmo-e2e-test-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy
Copy link
Member Author

mquhuy commented Jun 4, 2024

/test metal3-bmo-e2e-test-pull

@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch 2 times, most recently from cc19ded to 01a6197 Compare June 7, 2024 13:15
@mquhuy
Copy link
Member Author

mquhuy commented Jun 7, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-bmo-e2e-test-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy
Copy link
Member Author

mquhuy commented Jun 7, 2024

/test metal3-bmo-e2e-test-pull

@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch from 01a6197 to a3ed76d Compare June 18, 2024 10:04
@mquhuy
Copy link
Member Author

mquhuy commented Jun 18, 2024

/test metal3-bmo-e2e-test-pull

@metal3-io-bot
Copy link
Contributor

@mquhuy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test

In response to this:

/test metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch from a3ed76d to 0d08bf4 Compare June 18, 2024 11:18
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch 2 times, most recently from 79ebfc4 to 06c642c Compare June 18, 2024 11:19
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch 7 times, most recently from 9306172 to a500ab8 Compare June 19, 2024 08:23
@mquhuy
Copy link
Member Author

mquhuy commented Jun 19, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch from a500ab8 to b7a1406 Compare June 19, 2024 10:11
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Jul 3, 2024 •
edited
Loading

@mquhuy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-bmo-e2e-test-pull 01a6197 link false /test metal3-bmo-e2e-test-pull

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch 5 times, most recently from 85ca9bc to cda74da Compare July 3, 2024 12:29
@mquhuy
Copy link
Member Author

mquhuy commented Jul 3, 2024

/cc @tuminoid @mboukhalfa @adilGhaffarDev @Sunnatillo

@mquhuy mquhuy requested a review from Rozzii July 3, 2024 13:04
@Rozzii Rozzii modified the milestones: BMO - v0.6.2, BMO - v0.7.0 Jul 3, 2024
@mquhuy mquhuy mentioned this pull request Jul 4, 2024
Merged
@mquhuy mquhuy force-pushed the mquhuy/create-bmh-go branch from cda74da to dc60a39 Compare July 5, 2024 07:06
@kashifest
Copy link
Member

kashifest commented Jul 5, 2024 •
edited
Loading

/approve
I liked the overall idea hence and since the tests passed I am approving. I couldn't walk through every tiny details in the code hence I am putting a hold. Please unhold when theres a couple of more reviews or you have lgtm.

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2024
Rozzii
Rozzii reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@Rozzii Rozzii self-requested a review July 8, 2024 07:33
@Rozzii
Copy link
Member

Rozzii commented Jul 8, 2024

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 3d20976 into metal3-io:main Jul 8, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/create-bmh-go branch July 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii approved these changes

@elfosardo elfosardo Awaiting requested review from elfosardo

@kashifest kashifest Awaiting requested review from kashifest

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
BMO - v0.8
Development

Successfully merging this pull request may close these issues.

E2E: Make go tool for creating BMH VMs
4 participants
@mquhuy @metal3-io-bot @Rozzii @kashifest