-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 🌱 Use equinix runner instead of ubuntu for e2e tests #1775
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
82911d2
to
6d50f95
Compare
/retest |
Please add proper description and link to the relevant GH doc. It seems, e2e pipeline did not get a runner, as they are just "failed" with no run logs. Do we really want to use Equinix as they seem to be off most of the time? |
Its a WIP so not ready for review, I will add description once we know it works. |
We were suggested to try them in the CNCF cluster issue here cncf/cluster#266 (comment) . I have replied back what we experienced here. |
/retest |
6d50f95
to
3055681
Compare
/ok-to-test |
/retest |
/retest |
3055681
to
fda33e9
Compare
Still queued after 2.5 hours. |
@kashifest we'll investigate what's going on with the runners and get back to you. |
@tuminoid @kashifest I am troubleshooting this right now, thank you for your patience. The two pending jobs are https://github.com/metal3-io/baremetal-operator/actions/runs/11459855378/job/31885474716?pr=1775 and https://github.com/metal3-io/baremetal-operator/actions/runs/11459855378/job/31885475330?pr=1775 |
We are still working on determining the root cause of the problem. Since the last update, we have reviewed and checked org-level settings and restarted a cluster listener that should be picking this job up. I canceled and restarted the failed jobs a few times. We will continue to work on this and update you again in an hour. Thanks again for your patience. Let me know if this is an immediate blocker for the project. If not we appreciate your adoption of the runner and giving us this opportunity to figure out how to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We think that changing this line back to
runs-on: ${{ inputs.runner }}
will enable the job to be picked up by the appropriate CNCF Managed External GitHub Action runner.
Signed-off-by: Kashif Khan <[email protected]>
fda33e9
to
8826a31
Compare
It seems to have picked it up, but fails very early. Run sudo usermod -a -G libvirt $USER
Usage: usermod [options] LOGIN
... |
Yeah, @RobertKielty what kind of OS and which versions are these runners using? It would be good if you can point us to detailed information on these runners. |
@kashifest, you are correct that documentation is needed to describe the runners; full end-user documentation is not yet ready, as this iteration of the runners was deployed last week. The cluster and external runners are defined in the ci directory on the cncf/automation repo. So we can review the code that created the runners. The https://github.com/cncf/automation/tree/main/ci/cluster/equinix/runners/4cpu-16gb The Container Image is defined here Looking at the Dockerfile we have
The GHA runner image we use is based on ghcr.io/actions/actions-runner:latest from https://github.com/actions/runner We add typically needed packages as root and then revert to the Apologies again for not having full documentation in place; it is on our roadmap. Any and all feedback is very much appreciated! |
c06670d
to
dca3155
Compare
Signed-off-by: Kashif Khan <[email protected]>
dca3155
to
6736ba3
Compare
Testing Prow, ignore. |
/retest |
2 similar comments
/retest |
/retest |
OK, we're still missing Prow image bumps, no wonder it did not work. I'll retry later. |
/retest |
1 similar comment
/retest |
One last try. /retest |
/test all |
No description provided.