🌱 Always upload test artifacts, even if the tests fail #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
mquhuy
force-pushed
the
mquhuy/always-upload-test-artifacts
branch
from
3c62534 to
0bbee53
Compare
metal3-io-bot
requested review from
adilGhaffarDev,
kashifest,
Rozzii and
tuminoid
tuminoid
reviewed
Jun 19, 2024
Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/always-upload-test-artifacts
branch
from
0bbee53 to
7c66fb1
Compare
tuminoid
approved these changes
Jun 20, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, if a step in github action fails, the subsequent steps won't be run. This is not ideal in case of running e2e tests, as we would like the tests artifacts to be uploaded, even if the tests fail.
This PR enables test artifacts upload for failed tests.