Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Added Error message when reconciling loop is triggered more than once #1792

Merged
merged 4 commits into from
Oct 27, 2024
Merged

🌱 Added Error message when reconciling loop is triggered more than once #1792

merged 4 commits into from
Oct 27, 2024

Conversation

babugeet
Copy link
Contributor

What this PR does / why we need it:
Added Error message when reconciling loop is triggered more than once

Fixes #
#1787 (comment)

@metal3-io-bot
Copy link
Contributor

Hi @babugeet. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2024
@Rozzii Rozzii modified the milestones: BMO - v0.7.0, BMO - v0.6.2 Jun 28, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
@tuminoid
Copy link
Member

Please sign-off the work for DCO, and fix the linter nits.

@babugeet
Copy link
Contributor Author

@tuminoid : lint issues and DCO is fixed.. pls check

@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/cc @dtantsur @Rozzii

mquhuy
mquhuy reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@mquhuy mquhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

controllers/metal3.io/baremetalhost_controller.go Outdated Show resolved Hide resolved
controllers/metal3.io/bmceventsubscription_controller.go Outdated Show resolved Hide resolved
controllers/metal3.io/bmceventsubscription_controller.go Outdated Show resolved Hide resolved
controllers/metal3.io/baremetalhost_controller.go
return ctrl.Result{}, errors.Wrap(err, "failed to check services availability")
}
if !ready {
if err != nil || !ready {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log-wise, how is it different from just return an error if err != nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in some of the implementation of TryInit(), it was returning ready state as bool 'false' and at the same time err was nil. Also this is the standard followed in the code base

babugeet and others added 4 commits September 23, 2024 16:33
@babugeet
Added Error message when reconciling loop is triggered more than once
10ece0d 
Signed-off-by: “babugeet <[email protected]>”

Signed-off-by: babugeet <[email protected]>
@babugeet
fixed lint issues
db5f65d 
Signed-off-by: babugeet <[email protected]>

Signed-off-by: babugeet <[email protected]>
@babugeet
fixed review comments
fd86e40 
Signed-off-by: babugeet <[email protected]>
@babugeet
fixed review comments
3a4cabb 
Signed-off-by: babugeet <[email protected]>
Rozzii
Rozzii reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@mquhuy
Copy link
Member

mquhuy commented Oct 27, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2024
@metal3-io-bot metal3-io-bot merged commit 224a9b1 into metal3-io:main Oct 27, 2024
17 checks passed
@dtantsur
Copy link
Member

/cherry-pick release-0.8

@metal3-io-bot
Copy link
Contributor

@dtantsur: new pull request created: #2083

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mquhuy mquhuy mquhuy left review comments

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@kashifest kashifest Awaiting requested review from kashifest

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
BMO - v0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@babugeet @metal3-io-bot @tuminoid @mquhuy @dtantsur @Rozzii