✨ Add RBAC files for metrics authentication and authorization

[kashifest]

#2102 has introduced controller-runtime's WithAuthenticationAndAuthorization filter which also requires extra RBAC roles and role bindings for metrics authentication and authorization. This PR adds those.

[kashifest]

@camilamacedo86 I could identify these RBACs. Please check if this is sufficient. Thanks for your feedback so far.

[metal3-io-bot]

@camilamacedo86: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

That is great 🥇
Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mquhuy]

Some nits.
I'm not sure about the reason of the failure, but it didn't happen to me in local env. Have you tried rebasing the PR?

[kashifest]

Some nits. I'm not sure about the reason of the failure, but it didn't happen to me in local env. Have you tried rebasing the PR?

rebased but still failing.

[mquhuy]

I think I found the reason.

[kashifest]

/cc @lentzi90 @zaneb @dtantsur @elfosardo

[lentzi90]

/approve
Let's get this merged so we have a functioning metrics endpoint. Then we can improve on the e2e test later.

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

/lgtm

[tuminoid]

I put the backporting question to community meeting topic list tomorrow just to have concensus. It kinda feels right to backport, but also we might also get by using deprecated image for the time 0.8.

[camilamacedo86]

Hi @tuminoid

You can deprecate the old versions as well
But any version provided before with this image is risking not working when the image goes away.

[kashifest]

/cherry-pick release-0.8

[metal3-io-bot]

@kashifest: #2116 failed to apply on top of branch "release-0.8":

Applying: Add RBAC files for metrics authentication and authorization
Using index info to reconstruct a base tree...
M	config/render/capm3.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/render/capm3.yaml
Applying: Add e2e test for metrics service
Using index info to reconstruct a base tree...
M	config/base/manager.yaml
M	config/render/capm3.yaml
M	main.go
M	test/e2e/e2e_suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/e2e_suite_test.go
Auto-merging main.go
Auto-merging config/render/capm3.yaml
Auto-merging config/base/manager.yaml
CONFLICT (content): Merge conflict in config/base/manager.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Add e2e test for metrics service

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.