Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.7.9 #2119

Closed
wants to merge 313 commits into from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 11, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

metal3-io-bot and others added 30 commits May 13, 2024 15:40
…s/github.com/onsi/gomega-1.33.1

🌱 Bump github.com/onsi/gomega from 1.33.0 to 1.33.1
We are changing CI infrastructure. An unfortunate side-effect is that
some steps are taking longer than they used to. Because of this we now
see some timeouts.
This commit is for increasing the relevant timeouts to make the CI
stable again.

Signed-off-by: Lennart Jern <[email protected]>
This adds a function for retrying function calls that are flaky and
makes use of it for kustomizations.

Signed-off-by: Lennart Jern <[email protected]>
🌱 Refactoring: introduce inspecthardware.go
update_opts.go contains helpers for Ironic PATCH API that are not tied
to the provisioner and thus are better haused in the clients module
(renamed to match the existing convention).

updateopts_test.go is a mix of tests for update_opts.go and a few
provision-specific functions. The former are migrated to clients as
well, the latter - to the more suitable provision_test.py.

Signed-off-by: Dmitry Tantsur <[email protected]>
…imeout

🌱 E2E: Increase timeouts to stabilize CI
We add a few command-line flags to the baremetal-operator binary to
configure more ctrl.Options{}.

Signed-off-by: Honza Pokorny <[email protected]>
OWNERS_ALIASES groups are needed for fair blunderbuss review requests.

Signed-off-by: Tuomo Tanskanen <[email protected]>
TLS config code causes security linters to report false positive
about TLS versions that can be configured.

This is porting over CAPO PR 2037.

Signed-off-by: Tuomo Tanskanen <[email protected]>
…blic

🌱 Export BuildKustomizeManifest and GetKubeconfigPath functions in E2E
The content has been migrated there in an expanded form.

Signed-off-by: Dmitry Tantsur <[email protected]>
This adds issue templates for failing and flaky tests, consistent with
what we have in CAPM3 already.

Signed-off-by: Lennart Jern <[email protected]>
🌱 Link to the user guide for supported hardware
🌱 Add issue templates for flaky/failing tests
…nterface

 🐛 fix(redfish): set correct idrac-redfish management interface
⚠️ Remove hardware profile from the print columns
Drop all permissions on top-level. We're already giving out
actions: write on the job level.

Signed-off-by: Tuomo Tanskanen <[email protected]>
…permissions

🌱 explicitly drop pr approver workflow permissions
This improves the github workflow for fixture tests by uploading the
artifacts, similar to what we already have for jenkins jobs.

Signed-off-by: Lennart Jern <[email protected]>
…visioner-ironic-client

🌱 Add unit test on pkg/provisioner/ironic/client.go
Kubesec action has not been maintained for years. Kubesec itself is
maintained, and we'll see if we reintroduce it as prow test instead
of action later, or if we have enough coverage from existing tools.

Signed-off-by: Tuomo Tanskanen <[email protected]>
Signed-off-by: danish siddiqui <[email protected]>
…ow-artifacts

🌱 Upload artifacts from fixture tests
metal3-io-bot and others added 19 commits November 18, 2024 18:29
…-to-release-0.8

🌱 simplify go version handling in verify-release.sh
Signed-off-by: Honza Pokorny <[email protected]>
…-to-release-0.8

🌱 Add iurygregory as a reviewer
…-badge-release-0.8

📖 Add e2e status badge to readme
Using /dev/urandom has entropy issue. It can run out especially in CI,
leaving jobs stuck. We have used uuidgen in BMO e2e for long time now
and it works great. These usernames/passwords just need to be anything
random to make sure nothing is hardcoded, so uuidgen works great for
that anyways.

Signed-off-by: Tuomo Tanskanen <[email protected]>
…-to-release-0.8

🌱 use uuidgen to generate random username/password
Bump Go to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23.

Ignore couple new warnings that are generated, as there is no immediate
good options.

Cleanup golangci-lint config from deprecated configs.

Include timeouts where needed, golangci-lint 1.60 is defaulting to
real short runs and failing otherwise.

Signed-off-by: Tuomo Tanskanen <[email protected]>
…in-0.8

🌱 Bump Go to 1.23.3 and golangci-lint to 1.60.3
Bumps the kubernetes group with 3 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/component-base](https://github.com/kubernetes/component-base).
Bumps the kubernetes group with 2 updates in the /apis directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/client-go](https://github.com/kubernetes/client-go).
Bumps the kubernetes group with 3 updates in the /test directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/component-base](https://github.com/kubernetes/component-base).


Updates `k8s.io/api` from 0.29.10 to 0.29.11
- [Commits](kubernetes/api@v0.29.10...v0.29.11)

Updates `k8s.io/apimachinery` from 0.29.10 to 0.29.11
- [Commits](kubernetes/apimachinery@v0.29.10...v0.29.11)

Updates `k8s.io/client-go` from 0.29.10 to 0.29.11
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.10...v0.29.11)

Updates `k8s.io/component-base` from 0.29.10 to 0.29.11
- [Commits](kubernetes/component-base@v0.29.10...v0.29.11)

Updates `k8s.io/api` from 0.29.10 to 0.29.11
- [Commits](kubernetes/api@v0.29.10...v0.29.11)

Updates `k8s.io/apimachinery` from 0.29.10 to 0.29.11
- [Commits](kubernetes/apimachinery@v0.29.10...v0.29.11)

Updates `k8s.io/client-go` from 0.29.10 to 0.29.11
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.10...v0.29.11)

Updates `k8s.io/api` from 0.29.10 to 0.29.11
- [Commits](kubernetes/api@v0.29.10...v0.29.11)

Updates `k8s.io/apimachinery` from 0.29.10 to 0.29.11
- [Commits](kubernetes/apimachinery@v0.29.10...v0.29.11)

Updates `k8s.io/client-go` from 0.29.10 to 0.29.11
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.10...v0.29.11)

Updates `k8s.io/component-base` from 0.29.10 to 0.29.11
- [Commits](kubernetes/component-base@v0.29.10...v0.29.11)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <[email protected]>
…s/release-0.8/kubernetes-31b16c03eb

🌱 Bump the k8s.io/* deps to v0.29.11
Signed-off-by: babugeet <[email protected]>
Signed-off-by: babugeet <[email protected]>
…-to-release-0.8

🌱 Added Error message when reconciling loop is triggered more than once
❗ Following resources have been removed as part of this PR:

- ClusterRole: baremetal-operator-metrics-reader
- ClusterRole: baremetal-operator-proxy-role
- ClusterRoleBinding: baremetal-operator-proxy-rolebinding
- Service: baremetal-operator-controller-manager-metrics-service

Short description: kube-rbac-proxy was historically used to protect the metrics endpoint. However, its usage has been discontinued in Kubebuilder. The default scaffold now leverages the WithAuthenticationAndAuthorization feature provided by Controller-Runtime. This change is trigerred from the fact that the image gcr.io/kubebuilder/kube-rbac-proxy is deprecated and will become unavailable sometime from early 2025.

Signed-off-by: Kashif Khan <[email protected]>
…-proxy-release-0.8

✨ Remove kube-rbac-proxy and use controller run-time provided WithAuthenticationAndAuthorization filter instead
Signed-off-by: Huy Mai <[email protected]>
@metal3-io-bot metal3-io-bot added this to the BMO - v0.6 milestone Dec 11, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mquhuy mquhuy closed this Dec 11, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 11, 2024
@mquhuy mquhuy deleted the mquhuy/bump-capi-v1.7.9 branch December 11, 2024 12:27
@mquhuy mquhuy restored the mquhuy/bump-capi-v1.7.9 branch December 11, 2024 12:28
@mquhuy mquhuy deleted the mquhuy/bump-capi-v1.7.9 branch December 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.