Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add release github workflow #2132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 17, 2024

Now that the release workflow is working in IPAM, we can also add it to BMO repo.

Now that the release workflow is working in IPAM, we can also add it to
BMO repo.

Signed-off-by: Huy Mai <[email protected]>
@metal3-io-bot metal3-io-bot requested review from honza and zaneb December 17, 2024 11:16
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2024
@tuminoid
Copy link
Member

tuminoid commented Dec 17, 2024

We were supposed to add it after 1.9 so we can iron out all the issues to avoid fixing multiple repos. I don't think we have a single clean run in IPAM yet, nor have done patch releases with it etc.

We also agreed to make it reusable workflow before taking it in other repos.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Dec 17, 2024

We were supposed to add it after 1.9 so we can iron out all the issues to avoid fixing multiple repos. I don't think we have a single clean run in IPAM yet, nor have done patch releases with it etc.

We also agreed to make it reusable workflow before taking it in other repos. /hold

My intention is to have this in if we have IPAM release working. In case it doesn't work out, we should fix this PR and then test it out. IMO without taking this into use in other repos, it will take a long time to have a fully working solution.

The current setup in IPAM only fails in the build image step, which can be relatively easy to patch.

@tuminoid
Copy link
Member

Let's have this discussion in CAPM3 PR, no point pasting commentary to both PRs.
metal3-io/cluster-api-provider-metal3#2161

@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants