-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add release github workflow #2132
base: main
Are you sure you want to change the base?
Conversation
Now that the release workflow is working in IPAM, we can also add it to BMO repo. Signed-off-by: Huy Mai <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We were supposed to add it after 1.9 so we can iron out all the issues to avoid fixing multiple repos. I don't think we have a single clean run in IPAM yet, nor have done patch releases with it etc. We also agreed to make it reusable workflow before taking it in other repos. |
My intention is to have this in if we have IPAM release working. In case it doesn't work out, we should fix this PR and then test it out. IMO without taking this into use in other repos, it will take a long time to have a fully working solution. The current setup in IPAM only fails in the build image step, which can be relatively easy to patch. |
Let's have this discussion in CAPM3 PR, no point pasting commentary to both PRs. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Now that the release workflow is working in IPAM, we can also add it to BMO repo.