✨ Implement version picker for Ironic #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/L
The Ironic object now has a Version field that allows a user to request a specific version (latest or X.Y). Version 27.0 is added as supported. The Status is updated to support both installed and requested version (removing redundant nested structure). Signed-off-by: Dmitry Tantsur <[email protected]>
elfosardo
reviewed
Dec 5, 2024
| @@ -324,6 +337,32 @@ var _ = Describe("Ironic object tests", func() { | |||
| VerifyIronic(ironic) | |||
| }) | |||
|
|
|||
| It("creates Ironic of an oder version", Label("older-version"), func() { | |||
|
/cc @tuminoid |
lentzi90
approved these changes
Dec 9, 2024
tuminoid
reviewed
Dec 9, 2024
metal3-io-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ironic object now has a Version field that allows a user to request
a specific version (latest or X.Y). Version 27.0 is added as supported.
The Status is updated to support both installed and requested version
(removing redundant nested structure).
Signed-off-by: Dmitry Tantsur [email protected]