✨ Allows to provide ExtraConfig for Ironic conf #99
Conversation
Closes: metal3-io#87 Signed-off-by: Winicius Silva <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @winiciusallan. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
added
the
size/L
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
| @@ -194,6 +194,15 @@ type Images struct { | |||
| Keepalived string `json:"keepalived,omitempty"` | |||
| } | |||
|
|
|||
| type ExtraConfig struct { | |||
There was a problem hiding this comment.
I would probably add docs here
// ExtraConfig defines ....
Signed-off-by: Winicius Silva <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Winicius Silva <[email protected]>
Signed-off-by: Winicius Silva <[email protected]>
|
lgtm |
Closes: #87