🌱 Take Deploy-cli to replace deploy.sh #1447

mquhuy · 2024-08-13T06:36:46Z

~~This PR is currently used to test metal3-io/baremetal-operator#1669 Eventually we could consider merging it (to use deploy-cli in CI), but for now let's hold~~

This PR takes Deploy-cli into use to replace deploy.sh in dev-env deployment and tests.

metal3-io-bot · 2024-08-13T06:36:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mquhuy · 2024-08-13T06:37:42Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-08-13T06:38:58Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-08-14T07:17:11Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-08-14T09:53:48Z

/retest

mquhuy · 2024-08-15T08:20:12Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-08-15T09:56:09Z

/retest

mquhuy · 2024-08-16T11:18:10Z

/retest

mquhuy · 2024-08-16T12:47:37Z

/retest

mquhuy · 2024-08-20T15:16:36Z

/retest

mquhuy · 2024-08-21T11:59:19Z

/retest

mquhuy · 2024-09-03T12:05:29Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-09-03T14:22:55Z

/retest

mquhuy · 2024-09-16T10:29:11Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

mquhuy · 2024-09-16T12:11:55Z

/retest

mquhuy · 2024-09-16T14:10:46Z

Deploy-CLI was merged. Repurposing this PR as adaptation of the new tool to dev-env.

/retitle 🌱 Take Deploy-cli to replace deploy.sh

mquhuy · 2024-12-16T08:17:41Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

mquhuy · 2024-12-16T09:08:12Z

/retest

tuminoid · 2024-12-16T09:10:48Z

/retest

Retesting doesn't help, you need to fix the issue.

[2024-12-16T07:44:39.053Z] warning: Could not find remote branch fix-deploy-cli to clone.
[2024-12-16T07:44:39.053Z] fatal: Remote branch fix-deploy-cli not found in upstream origin

mquhuy · 2024-12-16T10:49:37Z

/retest

Retesting doesn't help, you need to fix the issue.

[2024-12-16T07:44:39.053Z] warning: Could not find remote branch fix-deploy-cli to clone.
[2024-12-16T07:44:39.053Z] fatal: Remote branch fix-deploy-cli not found in upstream origin

This is an old issue. It was fixed after the first fail.

mquhuy · 2024-12-16T10:55:45Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

mquhuy · 2024-12-16T10:56:26Z

/test metal3-centos-e2e-integration-test-release-1-7

mquhuy · 2024-12-16T11:18:12Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-centos-e2e-integration-test-release-1-7

mquhuy · 2024-12-16T12:59:26Z

/retest-required

mquhuy · 2024-12-16T14:38:27Z

/test metal3-centos-e2e-integration-test-release-1-8

mquhuy · 2024-12-17T07:54:48Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-centos-e2e-integration-test-release-1-7

mquhuy · 2024-12-17T08:09:04Z

/retest

mquhuy · 2024-12-17T08:45:06Z

/test metal3-centos-e2e-integration-test-release-1-8

mquhuy · 2024-12-17T09:09:45Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

tuminoid · 2024-12-17T09:13:57Z

02_configure_host.sh

+export DEPLOY_TOOL="${BMOPATH}/tools/deploy.sh"
+if [[ "${BMOBRANCH}" = "main" ]] || [[ "${BMOBRANCH}" = "release-0.9" ]]; then


Since deploy.sh is going away, make it the subject of condition, so we don't have to be adding releases in this list to keep it working.

Suggested change

export DEPLOY_TOOL="${BMOPATH}/tools/deploy.sh"

if [[ "${BMOBRANCH}" = "main" ]] || [[ "${BMOBRANCH}" = "release-0.9" ]]; then

if [[ "${BMOBRANCH}" =~ release-0.(8|6|5) ]]; then

export DEPLOY_TOOL="${BMOPATH}/tools/deploy.sh"

else

Now it is in two places?

Now that we have deploy-cli in BMO main, we can start using it to replace deploy.sh in installing BMO and Ironic. Signed-off-by: Huy Mai <[email protected]>

mquhuy · 2024-12-17T11:41:11Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

metal3-io-bot · 2024-12-17T13:22:13Z

@mquhuy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
metal3-centos-e2e-integration-test-release-1-7	`71bd2eb`	link	false	`/test metal3-centos-e2e-integration-test-release-1-7`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mquhuy · 2024-12-17T13:53:06Z

/test metal3-dev-env-integration-test-ubuntu-main

mquhuy · 2024-12-18T07:10:03Z

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024

metal3-io-bot requested review from elfosardo and tuminoid August 13, 2024 06:36

metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 50f68c9 to 62479c0 Compare August 13, 2024 06:37

mquhuy marked this pull request as draft August 13, 2024 06:38

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024

mquhuy marked this pull request as ready for review August 13, 2024 06:38

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024

metal3-io-bot requested review from dtantsur and kashifest August 13, 2024 06:38

mquhuy mentioned this pull request Aug 13, 2024

✨ Add Golang-based deploy-cli metal3-io/baremetal-operator#1669

Merged

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 62479c0 to 36505c0 Compare September 16, 2024 14:09

metal3-io-bot changed the title ~~DO NOT MERGE Test Deploy-cli~~ 🌱 Take Deploy-cli to replace deploy.sh Sep 16, 2024

mquhuy force-pushed the mquhuy/test-deploy-cli branch from dd73b39 to 6185294 Compare December 16, 2024 10:55

mquhuy changed the title ~~WIP 🌱 Take Deploy-cli to replace deploy.sh~~ 🌱 Take Deploy-cli to replace deploy.sh Dec 16, 2024

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 6185294 to 15726d4 Compare December 16, 2024 11:17

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 15726d4 to 71bd2eb Compare December 17, 2024 07:41

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 71bd2eb to f75dd9b Compare December 17, 2024 08:44

mquhuy force-pushed the mquhuy/test-deploy-cli branch from f75dd9b to 4f4e3e4 Compare December 17, 2024 09:09

tuminoid reviewed Dec 17, 2024

View reviewed changes

mquhuy force-pushed the mquhuy/test-deploy-cli branch 3 times, most recently from 49a82b7 to 6f9b837 Compare December 17, 2024 11:37

Take Deploy-cli into use to replace deploy.sh

5c22adb

Now that we have deploy-cli in BMO main, we can start using it to replace deploy.sh in installing BMO and Ironic. Signed-off-by: Huy Mai <[email protected]>

mquhuy force-pushed the mquhuy/test-deploy-cli branch from 6f9b837 to 5c22adb Compare December 17, 2024 11:41

		export DEPLOY_TOOL="${BMOPATH}/tools/deploy.sh"
		if [[ "${BMOBRANCH}" = "main" ]] \|\| [[ "${BMOBRANCH}" = "release-0.9" ]]; then

🌱 Take Deploy-cli to replace deploy.sh #1447

Are you sure you want to change the base?

🌱 Take Deploy-cli to replace deploy.sh #1447

Conversation

mquhuy commented Aug 13, 2024 • edited Loading

metal3-io-bot commented Aug 13, 2024

mquhuy commented Aug 13, 2024

mquhuy commented Aug 13, 2024

mquhuy commented Aug 14, 2024

mquhuy commented Aug 14, 2024

mquhuy commented Aug 15, 2024

mquhuy commented Aug 15, 2024

mquhuy commented Aug 16, 2024

mquhuy commented Aug 16, 2024

mquhuy commented Aug 20, 2024

mquhuy commented Aug 21, 2024

mquhuy commented Sep 3, 2024

mquhuy commented Sep 3, 2024

mquhuy commented Sep 16, 2024

mquhuy commented Sep 16, 2024

mquhuy commented Sep 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

tuminoid commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 16, 2024

mquhuy commented Dec 17, 2024

mquhuy commented Dec 17, 2024

mquhuy commented Dec 17, 2024

mquhuy commented Dec 17, 2024

tuminoid Dec 17, 2024

Choose a reason for hiding this comment

tuminoid Dec 17, 2024

Choose a reason for hiding this comment

mquhuy commented Dec 17, 2024

metal3-io-bot commented Dec 17, 2024 • edited Loading

mquhuy commented Dec 17, 2024

mquhuy commented Dec 18, 2024

mquhuy commented Aug 13, 2024 •

edited

Loading

metal3-io-bot commented Dec 17, 2024 •

edited

Loading