WIP: cleanup and reformat bash syntax in 04 script #1482
Conversation
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/XL
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
2d8d41b to
016badd
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main Running clusterctl upgrade tests as that seems to reveal all kinds of issues in 04 script before my changes. |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
016badd to
52a54e9
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
52a54e9 to
c6fe580
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
|
/retest |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
c6fe580 to
1b89f77
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
2 times, most recently
from
5006bab to
5cade36
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
1 similar comment
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
|
This is probably hitting some issues of own making and also same issue trying to be solved in #1480 |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
2 times, most recently
from
bf0a0e8 to
3984b9b
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-main metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
|
Clusterctl is now solved, thanks to Lennart's PR. This also passes locally if we wait longer for things to complete, so the |
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
3984b9b to
679ceb8
Compare
|
/test metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
|
@tuminoid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Cleanup and reforamt bash syntax in 04 script. Also requires fixes to lib/common.sh, but to keep PR contained, I rather took out the utility functions and put them in new lib/utils.sh. Also, fixed some leftover issues I missed first time around in 01, 02 and 03 scripts for consistency. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/cleanup-04-script
branch
from
679ceb8 to
d2ec209
Compare
Cleanup and reformat bash syntax in 04 script. Also requires fixes to lib/common.sh, but to keep PR contained, I rather took out the utility functions and put them in new lib/utils.sh, keeping lib/common.sh changes minimal.
Also, fixed some leftover issues I missed first time around in all root level scripts for consistency. Those should be nothing by indentation,
==removals, orsource -> .fixes, or shellcheck ignore corrections.