Fix VariableColorSettingComponent to display color correctly #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteraction Added a line that sets the color of the little preview window when the Pickr is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
(shows the correct color but only after an interaction)
before.mov
Now it works as expected.
This is a workaround fix.
I'm not sure why it was displaying like that in the first place. I hunted for the bug for bit but wasn't able to find it (it's possibly in @simonweb/pickr and I didn't want to mess with that).
I just added a line that explicitly sets the color immediately after the pickr component is created.
this.pickr.setColor(defaultColor);From my extremely minimal understanding of the repo, I think the line should be redundant but isn't.
If the underlying bug is fixed, this line should be deleted.