Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortReads_assembly.wdl should output bbcms error corrected data #18

Closed
aclum opened this issue May 9, 2024 · 4 comments · Fixed by #19
Closed

shortReads_assembly.wdl should output bbcms error corrected data #18

aclum opened this issue May 9, 2024 · 4 comments · Fixed by #19
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented May 9, 2024

The output of short read assembly should be included in the final output. The fastq headers do not need to be renamed but this should be included in the final workflow output and the workflow automation should make a data object for it.
This ticket is to get the WDL updated so that these bbcms task output files are get passed as outputs to the workflow, not just as outputs of the bbcms task.

        File out = filename_outfile
        File out1 = if paired then filename_outfile1 else filename_outfile
        File out2 = if paired then filename_outfile2 else filename_outfile
@vlilanl
Copy link
Contributor

vlilanl commented Jun 3, 2024

Shane and I tested this last week, and we had a successful run. @aclum do you want to look over it?

@aclum
Copy link
Contributor Author

aclum commented Jun 3, 2024

@vlilanl where is the run and would you be able to do a pull request?

@vlilanl
Copy link
Contributor

vlilanl commented Jun 3, 2024

This should be the run id: 8022a0d2-6443-457b-996f-de13b28cf337. I can try and do a pull request.

aclum added a commit that referenced this issue Jun 11, 2024
@vlilanl
Copy link
Contributor

vlilanl commented Jun 11, 2024

New ticket for nmdc_automation: microbiomedata/nmdc_automation#189

@vlilanl vlilanl closed this as completed Jun 11, 2024
@vlilanl vlilanl linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants