Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortreads bbcms #18 #19

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Shortreads bbcms #18 #19

merged 5 commits into from
Jun 11, 2024

Conversation

vlilanl
Copy link
Contributor

@vlilanl vlilanl commented Jun 5, 2024

Updated shortReads_assembly.wdl and jgi_assembly.wdl so that these bbcms task output files are also getting passed as outputs to the workflow. Created new input.json that works with Condor. Added labels.json and submit_curl.sh in order to test using Condor.

@vlilanl vlilanl requested review from scanon, aclum and kaijli June 5, 2024 16:55
@vlilanl vlilanl changed the title Shortreads #18 Shortreads bbcms #18 Jun 5, 2024
jgi_assembly.wdl Show resolved Hide resolved
@@ -214,6 +217,7 @@ task finish_asm {
cat ~{scaffold} | sed ~{sed} > ~{prefix}_scaffolds.fna
cat ~{covstats} | sed ~{sed} > ~{prefix}_covstats.txt
cat ~{agp} | sed ~{sed} > ~{prefix}_assembly.agp
cat ~{bbcms_fastq} | sed ~{sed} > ~{prefix}_bbcms.fastq.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to go through a sed command Ie the headers don't need to change, the file itself just needs to be changed.

@aclum aclum merged commit 5a56519 into master Jun 11, 2024
@aclum aclum deleted the bbcmsouts branch June 11, 2024 18:27
@vlilanl vlilanl linked an issue Jun 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortReads_assembly.wdl should output bbcms error corrected data
3 participants