-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce dependence on any_of in range constraints - all planned proces… #2246
base: main
Are you sure you want to change the base?
Conversation
…ses can be used in a 'was_generated_by' biosample slot
|
Is this sufficient or do we need a grouping class? |
@aclum—I looked at the descendants of PlannedProcess and we probably should discuss on a metadata call. From the definitions of the child classes of PlannedProcess, it seems that any of them could be the value of |
from modeling call:
|
@@ -444,12 +444,9 @@ slots: | |||
range: PersonValue | |||
description: Principal Investigator who led the study and/or generated the dataset. | |||
was_generated_by: | |||
range: WorkflowExecution | |||
range: PlannedProcess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from DM call:
the grouping here is that these two create a "dataobject", e.g. a "DataOutputter" class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataEmittingProcess?
@sierra-moxon - I think we should put a pin in trying to resolve the |
Can we document the new ones we need to add? It would be my preference if we could avoid adding to the any_of paradigm. |
…ses can be used in a 'was_generated_by' biosample slot