189 metaassembly output update v1.0.7 #298
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to added error corrected fastq data as the output of nmdc:MetagenomeAssembly
Updates for changes made to accommodate both a short and a long read workflow.
3 tasks
|
@mbthornton-lbl we need to be able to pass a boolean as an input metagenome assembly |
aclum
commented
Dec 4, 2024
| for _, inp_param in self.inputs.items(): | ||
| # Some input params are boolean values, skip these | ||
| if isinstance(inp_param, bool): | ||
| continue |
There was a problem hiding this comment.
@mbthornton-lbl this boolean needs to be pushed to the inp_param, not skipped. See https://github.com/microbiomedata/metaAssembly/blob/master/input.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
adds support for error corrected as an output from nmdc:MetagenomeAssembly
updates input parameters for nmdc:MetagenomeAssembly to accommodate changes made in 1.0.5
updates the output variable names to accommodate changes made in 1.0.5
Note we are on 1.0.7 now but we missed completing the needed changes for 1.0.5.