Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

293 scheduler not handling nmdc:MetagenomeSequencing #294

Closed
wants to merge 8 commits into from

Conversation

mbthornton-lbl
Copy link
Contributor

This PR provides a fix for #293

Root cause of the error was failure to handle nmdc:MetagenomeSequencing workflow executions correctly.

Changes in this PR

  • update workflow_process.py to correctly handle Metagenome Sequencing as a sort-of data generation
  • update workflows.yaml with new workflow
  • update models.nmdc workflow_process_factory to handle the type
  • unit tests for workflow_process and scheduler.cycle
  • new test fixtures

@mbthornton-lbl mbthornton-lbl requested a review from aclum November 20, 2024 20:47
@mbthornton-lbl mbthornton-lbl linked an issue Nov 20, 2024 that may be closed by this pull request
@mbthornton-lbl mbthornton-lbl changed the title 293 scheduler failing with valueerror 293 scheduler not handling nmdc:MetagenomeSequencing Nov 20, 2024
@mbthornton-lbl
Copy link
Contributor Author

We are going to skip the nmdc:MetagenomeSequencing type

@mbthornton-lbl mbthornton-lbl deleted the 293-scheduler-failing-with-valueerror branch November 20, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant