Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always update job metadata in process_successful_job #318

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Always update job metadata in process_successful_job #318

merged 1 commit into from
Dec 5, 2024

Conversation

mbthornton-lbl
Copy link
Contributor

This PR addresses #315

The sequence of log messages:

2024-12-04 00:00:00,504 INFO: Found 1 successful jobs.
2024-12-04 00:00:00,504 INFO: Processing successful job: nmdc:sys0sc99je06, nmdc:wfmgan-12-z1vfrs19.1
2024-12-04 00:00:00,504 INFO: Process successful job:  nmdc:sys0sc99je06
2024-12-04 00:00:00,736 INFO: Processing output annotation.proteins_faa

Show that the optional step to update job metadata had been skipped based on the if condition. This PR makes updating the metadata for a successful job non-optional

@mbthornton-lbl mbthornton-lbl linked an issue Dec 4, 2024 that may be closed by this pull request
Watcher process successful job failing with key error #315
Closed
@mbthornton-lbl mbthornton-lbl merged commit b6b18ac into main Dec 5, 2024
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the 315-watcher-process-successful-job-failing-with-key-error branch December 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclum aclum aclum approved these changes

@scanon scanon Awaiting requested review from scanon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watcher process successful job failing with key error
2 participants
@mbthornton-lbl @aclum