Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete re-iding code #320

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mbthornton-lbl
Copy link
Contributor

@mbthornton-lbl mbthornton-lbl commented Dec 4, 2024

This PR removes obsolete re-iding code from the repo:

  • add archive dir and move re-iding logs and data files there
  • delete obsolete re_iding code and supporting code
  • fixed a couple of file-staging unit tests

@mbthornton-lbl mbthornton-lbl linked an issue Dec 4, 2024 that may be closed by this pull request
@mbthornton-lbl mbthornton-lbl requested a review from aclum December 5, 2024 16:05
@mbthornton-lbl mbthornton-lbl marked this pull request as ready for review December 5, 2024 16:05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth moving any of this to nmdc-runtime? @dwinston @shreddd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been going towards using the queries:run endpoint for making updates to data, fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete re-iding code
2 participants