Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate styled-system #1679

Merged
merged 58 commits into from
Jul 20, 2024
Merged

migrate styled-system #1679

merged 58 commits into from
Jul 20, 2024

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Dec 31, 2023 •
edited
Loading

to review

  • home
  • styleguide
  • recipes
  • recipes/:id
  • privacy
  • tos
  • blog
  • blog/:id
  • docs
  • dpa
  • changelog
  • community
  • design
  • enterprise
  • formats
  • insights
  • logo
  • meta
  • newsletter
  • oss
  • pdf
  • screenshot
  • sdk
  • status
  • user-agents
  • payment
  • payment/update

@vercel Vercel
Copy link

vercel bot commented Dec 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 4:01pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 4:01pm

@Kikobeats Kikobeats changed the title refactor: remove Fixed component WIP: migrate styled-components Jan 1, 2024
The-Code-Monkey
The-Code-Monkey reviewed Jan 2, 2024
View reviewed changes
Copy link

@The-Code-Monkey The-Code-Monkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still recommend using compose as it speeds up runtime

@Kikobeats Kikobeats force-pushed the styled-components branch from 5f5faab to b16a1dd Compare March 3, 2024 10:23
@Kikobeats Kikobeats force-pushed the styled-components branch from b16a1dd to 19295f7 Compare March 3, 2024 17:23
@Kikobeats Kikobeats force-pushed the styled-components branch from 19295f7 to 07eed48 Compare March 3, 2024 17:34
@Kikobeats Kikobeats force-pushed the styled-components branch from 07eed48 to a2abeec Compare March 3, 2024 17:54
@Kikobeats Kikobeats force-pushed the styled-components branch from a2abeec to c190847 Compare March 3, 2024 19:55
@Kikobeats Kikobeats force-pushed the styled-components branch from c190847 to 45da260 Compare March 6, 2024 14:15
@Kikobeats
Copy link
Member Author

@breadadams @The-Code-Monkey finally shipped 🎉

@Kikobeats Kikobeats merged commit a313d80 into master Jul 20, 2024
6 checks passed
@Kikobeats Kikobeats deleted the styled-components branch July 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Code-Monkey The-Code-Monkey The-Code-Monkey left review comments

@breadadams breadadams breadadams left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kikobeats @The-Code-Monkey @breadadams