Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OtelTraceContextBuilder set parentId sampled as nullable as in TraceContext #910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OtelTraceContextBuilder set parentId sampled as nullable as in TraceContext #910

wants to merge 1 commit into from

Conversation

binig
Copy link

@binig binig commented Dec 13, 2024 •
edited
Loading

#911

in the TraceContext
parentId and sampled are nullable.

In the current OtelTraceContext if try to build a context without specify sampled u can an autoboxing NPE

@binig binig marked this pull request as ready for review December 13, 2024 13:36
@binig binig mentioned this pull request Dec 13, 2024
Open
shakuzen
shakuzen reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Let's add some tests for this so we don't have a regression around this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binig @shakuzen