Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVE-2024-37891 for python-pip :3.0 #11181

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Fix CVE-2024-37891 for python-pip :3.0 #11181

merged 7 commits into from
Nov 25, 2024

Conversation

KavyaSree2610
Copy link
Contributor

@KavyaSree2610 KavyaSree2610 commented Nov 22, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@KavyaSree2610 KavyaSree2610 marked this pull request as ready for review November 22, 2024 10:59
@KavyaSree2610 KavyaSree2610 requested a review from a team as a code owner November 22, 2024 10:59
@KavyaSree2610 KavyaSree2610 changed the title Fix CVE-2024-37891 for tensorflow and python-pip Fix CVE-2024-37891 for tensorflow and python-pip :3.0 Nov 22, 2024
@mbykhovtsev-ms
Revert tensorflow patch
c09bb1d 
We do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched
@mbykhovtsev-ms
Delete SPECS/tensorflow/CVE-2024-37891.patch
1c4f64f 
We do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched
mbykhovtsev-ms
mbykhovtsev-ms reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the tensorflow patch changes because we do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched. But the python-pip patch looks good!

@mbykhovtsev-ms mbykhovtsev-ms changed the title Fix CVE-2024-37891 for tensorflow and python-pip :3.0 Fix CVE-2024-37891 for python-pip :3.0 Nov 25, 2024
@jslobodzian jslobodzian merged commit 8e48f52 into fasttrack/3.0 Nov 25, 2024
11 of 15 checks passed
@jslobodzian jslobodzian deleted the kkaitepalli/CVE-2024-37891 branch November 25, 2024 19:53
CBL-Mariner-Bot pushed a commit that referenced this pull request Nov 25, 2024
@KavyaSree2610 @CBL-Mariner-Bot
Fix CVE-2024-37891 for python-pip :3.0 (#11181)
4949ad9 
Co-authored-by: kavyasree <[email protected]>
Co-authored-by: Mykhailo Bykhovtsev <[email protected]>
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 8e48f52)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Nov 25, 2024
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=682870&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbykhovtsev-ms mbykhovtsev-ms mbykhovtsev-ms approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees
No one assigned
Labels
Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KavyaSree2610 @CBL-Mariner-Bot @jslobodzian @mbykhovtsev-ms