ImageCustomizer: Add Support for Configuring User Sudoers File #11196
Conversation
| return nil | ||
| } | ||
|
|
||
| func UpdateSudoAccess(installChroot safechroot.ChrootInterface, username string, enableSudo bool) error { |
There was a problem hiding this comment.
Was trying to put this function inside userutils.py but will create cyclic dependency issue.
| @@ -20,6 +20,7 @@ type User struct { | |||
| SecondaryGroups []string `yaml:"secondaryGroups"` | |||
| StartupCommand string `yaml:"startupCommand"` | |||
| HomeDirectory string `yaml:"homeDirectory"` | |||
| Sudo bool `yaml:"sudo"` | |||
There was a problem hiding this comment.
Is this setting specifically enabling no-password sudo? If that's the case, then could we make the setting name appropriately specific to that? Given that this is a security-impacting setting, I think we should be as clear as we can about what the image owner is opening up.
| }, | ||
| } | ||
|
|
||
| err := CopyAdditionalFiles(sudoersFile, additionalFiles, installChroot) |
There was a problem hiding this comment.
You don't need to use CopyAdditionalFiles. Just write to the file using file.Write. (You can use installChroot .RootDir() to get the rootfs directory.)
| @@ -17,8 +17,8 @@ const ( | |||
| defaultFilePermissions = 0o755 | |||
| ) | |||
|
|
|||
| func copyAdditionalFiles(baseConfigPath string, additionalFiles imagecustomizerapi.AdditionalFileList, | |||
| imageChroot *safechroot.Chroot, | |||
| func CopyAdditionalFiles(baseConfigPath string, additionalFiles imagecustomizerapi.AdditionalFileList, | |||
There was a problem hiding this comment.
You don't need to make a function public if you are accessing it from the same package/directory.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
Summary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Test Methodology