Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #250

Merged
merged 3 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ deploy-ms-idp: ## 🔐 Create an Identity Provider
@echo -e "\e[34m$@\e[0m" || true
cd deploy && pwsh ./New-IdentityProvider.ps1

generate-access-token: ## 🔐 Generate and access token
generate-access-token: ## 🔐 Generate an access token
@echo -e "\e[34m$@\e[0m" || true
./scripts/generate_access_token.sh

Expand Down
2 changes: 1 addition & 1 deletion data-reconciliation-app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ deploy-mccf: ## 🚀 Deploy Managed CCF
deploy-ms-idp: ## 🔐 Create an Identity Provider
@cd .. && $(MAKE) deploy-ms-idp

generate-access-token: ## 🔐 Generate and access token
generate-access-token: ## 🔐 Generate an access token
@cd .. && $(MAKE) generate-access-token

# Keep this at the bottom.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ When a user requests a reconciliation report via the `/report` endpoint, it is g

This decouples data ingestion from reconciliation reporting.

Reconciliation is implemented by querying CFF KV Store for all the keys this user has submitted. Any keys unknown to this user are not used in the reconciliation report. This ensures the user only sees a report with their submitted data.
Reconciliation is implemented by querying CCF KV Store for all the keys this user has submitted. Any keys unknown to this user are not used in the reconciliation report. This ensures the user only sees a report with their submitted data.

## Scenarios

Expand Down
18 changes: 9 additions & 9 deletions data-reconciliation-app/src/repositories/kv-repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,54 +3,54 @@ import { ReconciledRecord } from "../models/reconciled-record";
import { ServiceResult } from "../utils/service-result";

/**
* Generic Key-Value implementation wrapping CFF TypedKvMap storage engine
* Generic Key-Value implementation wrapping CCF TypedKvMap storage engine
*/
export interface IRepository<T> {
/**
* Store {T} in CFF TypedKvMap storage by key
* Store {T} in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
set(key: string, value: T): ServiceResult<T>;

/**
* Retrive {T} in CFF TypedKvMap storage by key
* Retrive {T} in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
get(key: string): ServiceResult<T>;

/**
* Check if {T} exists in CFF TypedKvMap storage by key
* Check if {T} exists in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
has(key: string): ServiceResult<boolean>;

/**
* Retrieve all keys in CFF TypedKvMap storage
* Retrieve all keys in CCF TypedKvMap storage
*/
keys(): ServiceResult<string[]>;

/**
* Retrieve all values in CFF TypedKvMap storage
* Retrieve all values in CCF TypedKvMap storage
*/
values(): ServiceResult<T[]>;

/**
* Get size of CFF TypedKvMap storage
* Get size of CCF TypedKvMap storage
* @returns {ServiceResult<number>}
*/
get size(): ServiceResult<number>;

/**
* Iterate through CFF TypedKvMap storage by key
* Iterate through CCF TypedKvMap storage by key
* @param callback
*/
forEach(callback: (key: string, value: T) => void): ServiceResult<string>;

/**
* Clears CFF TypedKvMap storage
* Clears CCF TypedKvMap storage
*/
clear(): ServiceResult<void>;
}
Expand Down
4 changes: 2 additions & 2 deletions data-reconciliation-app/src/utils/api-result.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export enum StatusCode {
}

/**
* Status code for CFF network conventions
* Status code for CCF network conventions
*/
export interface CCFResponse {
statusCode: number;
Expand All @@ -19,7 +19,7 @@ export interface CCFResponse {
}

/**
* Utility class for wrapping the response with CFF network conventions
* Utility class for wrapping the response with CCF network conventions
*/
export class ApiResult {
/**
Expand Down
16 changes: 8 additions & 8 deletions decentralize-rbac-app/src/repositories/kv-repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,50 +7,50 @@ import { ServiceResult } from "../utils/service-result";
*/
export interface IRepository<T> {
/**
* Store {T} in CFF TypedKvMap storage by key
* Store {T} in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
set(key: string, value: T): ServiceResult<T>;

/**
* Retrive {T} in CFF TypedKvMap storage by key
* Retrive {T} in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
get(key: string): ServiceResult<T>;

/**
* Check if {T} exists in CFF TypedKvMap storage by key
* Check if {T} exists in CCF TypedKvMap storage by key
* @param {string} key
* @param {T} value
*/
has(key: string): ServiceResult<boolean>;

/**
* Retrieve all keys in CFF TypedKvMap storage
* Retrieve all keys in CCF TypedKvMap storage
*/
keys(): ServiceResult<string[]>;

/**
* Retrieve all values in CFF TypedKvMap storage
* Retrieve all values in CCF TypedKvMap storage
*/
values(): ServiceResult<T[]>;

/**
* Get size of CFF TypedKvMap storage
* Get size of CCF TypedKvMap storage
* @returns {ServiceResult<number>}
*/
get size(): ServiceResult<number>;

/**
* Iterate through CFF TypedKvMap storage by key
* Iterate through CCF TypedKvMap storage by key
* @param callback
*/
forEach(callback: (key: string, value: T) => void): ServiceResult<string>;

/**
* Clears CFF TypedKvMap storage
* Clears CCF TypedKvMap storage
*/
clear(): ServiceResult<void>;

Expand Down
4 changes: 2 additions & 2 deletions decentralize-rbac-app/src/utils/api-result.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export enum StatusCode {
}

/**
* Status code for CFF network conventions
* Status code for CCF network conventions
*/
export interface CCFResponse {
statusCode: number;
Expand All @@ -19,7 +19,7 @@ export interface CCFResponse {
}

/**
* Utility class for wrapping the response with CFF network conventions
* Utility class for wrapping the response with CCF network conventions
*/
export class ApiResult {
/**
Expand Down
Loading