Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing operators and ctors for http_request and http_response #1668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Missing operators and ctors for http_request and http_response #1668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa216d5
Missing operators and ctors for http_request and http_response
Dec 13, 2021
a8dccb3
Remove all redundant code and make compiler generate copy and move fu…
Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Release/include/cpprest/http_msg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,8 @@ class _http_response final : public http::details::http_msg_base

_http_response(http::status_code code) : m_status_code(code) {}

virtual _http_response() = default;

http::status_code status_code() const { return m_status_code; }

void set_status_code(http::status_code code) { m_status_code = code; }
Expand Down Expand Up @@ -853,7 +855,7 @@ class _http_request final : public http::details::http_msg_base, public std::ena

_ASYNCRTIMP _http_request(std::unique_ptr<http::details::_http_server_context> server_context);

virtual ~_http_request() {}
virtual ~_http_request() = default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?


http::method& method() { return m_method; }

Expand Down Expand Up @@ -951,11 +953,6 @@ class http_request
/// <param name="mtd">Request method.</param>
http_request(http::method mtd) : _m_impl(std::make_shared<http::details::_http_request>(std::move(mtd))) {}

/// <summary>
/// Destructor frees any held resources.
/// </summary>
~http_request() {}

/// <summary>
/// Get the method (GET/PUT/POST/DELETE) of the request message.
/// </summary>
Expand Down