Spelling #1813
Open
Spelling #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Dec 12, 2024
| @@ -1 +1 @@ | |||
| Please consult the documentation [here](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS) for iOS compilation. | |||
| Please consult the [documentation for iOS compilation](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS). | |||
There was a problem hiding this comment.
This is based on an accessibility complaint (for people using screen readers):
Do not use (click) here links
For more information, see:
- https://www.w3.org/QA/Tips/noClickHere
- https://webaim.org/techniques/hypertext/link_text
- https://granicus.com/blog/why-click-here-links-are-bad/
- https://heyoka.medium.com/dont-use-click-here-f32f445d1021
(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()
| @@ -782,7 +782,7 @@ enum json_error | |||
| malformed_numeric_literal, | |||
| malformed_string_literal, | |||
| malformed_token, | |||
| mismatched_brances, | |||
| mismatched_braces, | |||
| @@ -17,7 +17,7 @@ | |||
| <TranslateTransform/> | |||
| </TransformGroup> | |||
| </Canvas.RenderTransform> | |||
| <Image HorizontalAlignment="Left" Source="Cards.PNG" Stretch="None" VerticalAlignment="Top" RenderTransformOrigin="0.05,0.08" x:Name="imgCard"> | |||
| <Image HorizontalAlignment="Left" Source="cards.png" Stretch="None" VerticalAlignment="Top" RenderTransformOrigin="0.05,0.08" x:Name="imgCard"> | |||
There was a problem hiding this comment.
the corresponding reference is renamed above
| @@ -1417,7 +1417,7 @@ utility::string_t __cdecl timespan::seconds_to_xml_duration(utility::seconds dur | |||
| } | |||
|
|
|||
| // The format is: | |||
| // PdaysDThoursHminutesMsecondsS | |||
| // "P"+(days+"D")?+"T"+(hours+"H")?+(minutes+"M")?+(seconds+"S")? | |||
There was a problem hiding this comment.
this was a very manual change. I don't think the previous text was particularly readable...
| @@ -148,13 +148,13 @@ SUITE(proxy_tests) | |||
| TEST_FIXTURE(uri_address, | |||
| http_proxy_with_credentials, | |||
| "Ignore:Linux", | |||
| "Github 53", | |||
| "GitHub 53", | |||
There was a problem hiding this comment.
I'm not sure what this is doing, it's possible it can't be applied... happy to drop if it's a problem...
| @@ -45,7 +45,7 @@ listed below. | |||
|
|
|||
| base64.cpp and base64.h | |||
|
|
|||
| Copyright (C) 2004-2008 Ren� Nyffenegger | |||
| Copyright (C) 2004-2008 Ren� Nyffenegger | |||
There was a problem hiding this comment.
I'm not sure what happened to this line. I blame VS Code
|
|
||
| ****** SHA1 Library (sha1/sha1.hpp) ****** | ||
| sha1.hpp is a repackaging of the sha1.cpp and sha1.h files from the shallsha1 | ||
| sha1.hpp is a repackaging of the sha1.cpp and sha1.h files from the smallsha1 |
There was a problem hiding this comment.
I don't normally change files like this, but this typo seemed sufficiently problematic/worthy of correcting.
| @@ -15,7 +15,7 @@ cpprestsdk (2.10.18) | |||
|
|
|||
| cpprestsdk (2.10.17) | |||
| * PR#1550 Fix year calculation for the last day of a leap year | |||
| * PR#1523 Fix wrong linking of Apple Frameworks on MacOS | |||
| * PR#1523 Fix wrong linking of Apple Frameworks on macOS | |||
There was a problem hiding this comment.
Some projects don't like changing changelogs, I'm happy to drop this (or anything else) if it's a problem.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action (which is an evolution of the script I used ages ago when I first made a PR here...).
The misspellings have been reported at https://github.com/jsoref/cpprestsdk/actions/runs/12292228454#summary-34302451221
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/cpprestsdk/actions/runs/12292228864#summary-34302452484