Changes for HyperV-Socket agent's CAs certificates #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpc/nodeagent/security/certificate/moc_nodeagent_certificate.proto
Outdated
Show resolved
Hide resolved
algamaes
force-pushed
the
algamaes/intermediate_ca
branch
from
3727f9b
to
7bcf508
Compare
raghavendra-nataraj
previously approved these changes
Jul 22, 2023
|
Can you check why the tests are failing? |
|
@raghavendra-nataraj I had missing cherry-picking a fix from another branch I had, sorry. Let's not merge this PR until node's PR is approved, because the new methods added to node certificates will fail the builds until they're implemented. |
|
Can we introduce stubs to avoid the build issue? |
manoj-kadam
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.