External Execution Interface #4616
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
Area: Performance
Area: API
Area: Core
nibanks
commented
Oct 16, 2024
nibanks
changed the title
nibanks
commented
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4616 +/- ##
==========================================
- Coverage 86.98% 86.71% -0.28%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15096 15049 -47
- Misses 2258 2305 +47 ☔ View full report in Codecov by Sentry. |
nibanks
commented
Oct 16, 2024
mtfriesen
reviewed
Oct 16, 2024
| ULONG OverlappedCount = 0; | ||
| if (GetQueuedCompletionStatusEx(IOCP, Overlapped, ARRAYSIZE(Overlapped), &OverlappedCount, WaitTime, FALSE)) { | ||
| for (ULONG i = 0; i < OverlappedCount; ++i) { | ||
| QUIC_CQE* Cqe = CONTAINING_RECORD(Overlapped[i].lpOverlapped, QUIC_CQE, Overlapped); |
There was a problem hiding this comment.
is anything creating QUIC_CQEs in this sample program?
There was a problem hiding this comment.
No, not yet. I will add one.
mtfriesen
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1923.
Provides an interface for the application layer to completely control execution of all MsQuic work. In other words, MsQuic would create no threads internally.
Testing
TODO
Documentation
TODO