Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes from django-mssql-backend #9

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Backport fixes from django-mssql-backend #9

merged 4 commits into from
Mar 19, 2021

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Mar 3, 2021

This PR features several PRs previously made on https://github.com/ESSolutions/django-mssql-backend:

and fixes manage.py to be able to run tests; the hashbash line isn't first meaning it couldn't be executed as ./manage.py directly.

davidjb added 4 commits March 3, 2021 15:00
@davidjb
Put hashbang on first line of manage.py
e8c53c8
@davidjb
Fix host_is_server URL and expand docs in README
23524b5
@davidjb
Backwards compatibility for deferrable kwarg
762c464 
This was previously accepted to the original repository in
ESSolutions/django-mssql-backend#86.

Backwards compatibility for Django < 3.1 is maintained by not directly
trying to load the supports_deferrable_unique_constraints via dot
notation, but rather by getattr with a default.
@davidjb
Error on unsupported unique constraint conditions
c063460 
CREATE INDEX in SQL Server only supports AND conditions (not OR) as part
of its WHERE syntax. This change handles that situation by raising an
error from the schema editor class. This change adds unit tests to
confirm this happens against a SQL Server database.

Previously opened at ESSolutions/django-mssql-backend#97
This was referenced Mar 3, 2021
Merged
Open
@davidjb davidjb mentioned this pull request Mar 18, 2021
Open
absci
absci approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@absci absci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, this will help the user experience.

@absci absci merged commit 35bacff into microsoft:dev Mar 19, 2021
@davidjb
Copy link
Contributor Author

davidjb commented Mar 20, 2021

Thanks @absci - much appreciated. Would it be possible to create a new PyPI release? Thank you!

@absci
Copy link
Contributor

absci commented Mar 23, 2021

Thanks @absci - much appreciated. Would it be possible to create a new PyPI release? Thank you!

No problem, we don't really have a schedule for the next release yet, but it should be soon.

@Trezorro
Copy link

Trezorro commented Jun 15, 2021 •
edited
Loading

Hi @absci I've trying to get MSSQL working with django 3.1, running into the issues metntioned here as well as #25 . It seems like these should be fixed, but I don't see a new release on Pypi. Could you update us on the schedule?
Meanwhile, is it safe to install from src?

@absci
Copy link
Contributor

absci commented Jun 16, 2021

Hi @absci I've trying to get MSSQL working with django 3.1, running into the issues metntioned here as well as #25 . It seems like these should be fixed, but I don't see a new release on Pypi. Could you update us on the schedule?
Meanwhile, is it safe to install from src?

It's generally safe to install from source, I don't have updates for the schedule yet.

@mbehn
Copy link

mbehn commented Jun 22, 2021

hi @absci I am trying to deploy with Django 3.2 and am having this same issue. Seeing if you might have an update on when Pypi will be updated.

@vwarchu
Copy link
Contributor

vwarchu commented Jun 22, 2021

Hi @mbehn , Pypi will be updated June 30, 2021 with version 1.0rc1. The GA release is scheduled to be released on Pypi on July 29, 2021. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absci absci absci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidjb @absci @Trezorro @mbehn @vwarchu