Skip to content

Commit

Permalink
UefiCpuPkg: CpuPageTableLib: Remove Empty Test Suite
Browse files Browse the repository at this point in the history
RandomeTestCase in CpuPageTableLib has had all of its tests
commented out, but the suite itself is still present, so it
creates errors in tools that look for empty test suites being
registered.

Signed-off-by: Oliver Smith-Denny <[email protected]>
  • Loading branch information
os-d committed Aug 24, 2024
1 parent 47134bd commit f481172
Showing 1 changed file with 10 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,8 @@ UefiTestMain (
EFI_STATUS Status;
UNIT_TEST_FRAMEWORK_HANDLE Framework;
UNIT_TEST_SUITE_HANDLE ManualTestCase;
UNIT_TEST_SUITE_HANDLE RandomTestCase;

// UNIT_TEST_SUITE_HANDLE RandomTestCase; // MU_CHANGE: Remove Empty Test Suite

Framework = NULL;

Expand Down Expand Up @@ -874,12 +875,14 @@ UefiTestMain (
//
// Populate the Random Test Cases.
//
Status = CreateUnitTestSuite (&RandomTestCase, Framework, "Random Test Cases", "CpuPageTableLib.Random", NULL, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Failed in CreateUnitTestSuite for Random Test Cases\n"));
Status = EFI_OUT_OF_RESOURCES;
goto EXIT;
}
// MU_CHANGE START: Remove Empty Test Suite
// Status = CreateUnitTestSuite (&RandomTestCase, Framework, "Random Test Cases", "CpuPageTableLib.Random", NULL, NULL);
// if (EFI_ERROR (Status)) {
// DEBUG ((DEBUG_ERROR, "Failed in CreateUnitTestSuite for Random Test Cases\n"));
// Status = EFI_OUT_OF_RESOURCES;
// goto EXIT;
// }
// MU_CHANGE END: Remove Empty Test Suite

// AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
// AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
Expand Down

0 comments on commit f481172

Please sign in to comment.