Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal netlink errors with exceptions #162

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Signal netlink errors with exceptions #162

merged 10 commits into from
Feb 22, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Handle errors from using netlink are surfaced and handled consistently.

Technical Details

  • Add NetlinkException and NetlinkErrorCategory concepts that are compatible with std:: error handling patterns using std:;exception as the base type.
  • Replace throwing the integer netlink return value with throw NetlinkException.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 22, 2024 22:12
@abeltrano abeltrano merged commit 3c2e603 into develop Feb 22, 2024
5 checks passed
@abeltrano abeltrano deleted the strongexcepttype branch February 22, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant