Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using insecure gRPC CMake targets #96

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Attempt to enable building for Windows ARM64 architecture, specifically the ARM64EC ABI.

Technical Details

  • Replace use of standard gRPC CMake targets with "unsecure" ones, which do not link SSL dependents.
  • Add CMake configure preset for building ARM64 on Windows.

Test Results

  • Cross-compile build for ARM64 on Windows with Debug flavor succeeded.

Reviewer Focus

  • None

Future Work

  • Using the insecure targets is not desirable. While this framework is intended mostly for test environments where security may not be required or important, having a secure transport should be an option for corner cases. So, we need to figure out a workaround to enable use of the normal targets that support SSL.
  • Enable use of SSL in gRPC transport #95

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 9, 2024 23:30
@abeltrano abeltrano merged commit 8259741 into develop Jan 10, 2024
2 of 4 checks passed
@abeltrano abeltrano deleted the grpcunsecure branch January 10, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant