Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg port features #99

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Add vcpkg port features #99

merged 9 commits into from
Jan 10, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow consumers to choose which project features to build.

Technical Details

  • Introduce vcpkg features protocol, server, tests, and tools, with protocol being the sole default feature.
  • Rename existing CMake test exclusion variable to match the vcpkg feature option variable names.

Test Results

  • Built the project with default features for arm64 (with EC ABI) and amd64 both locally and in the Windows build system and verified they are end-to-end successful, including the link stage which was previously broken for arm64.

Reviewer Focus

  • Consider how this might impact the developer inner loop, if at all.

Future Work

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 10, 2024 21:09
@abeltrano abeltrano merged commit bd3e3da into develop Jan 10, 2024
1 check passed
@abeltrano abeltrano deleted the vcpkgfeatures branch January 10, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant