fix: added reset before embeding #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Hello @GMProg , We were not able to reproduce this issue. Could you please provide repro steps, so we can understand about the issue and the resolution provided by you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset before embeding, there was an issue where an already embeded/bootstrapped element could not be re-embeded, this is due to an error/limitation in the "powerbi-client" package, where the Embed class's "load" function call fails with the following error: "DOMException: Failed to execute 'postMessage' on 'Window': # could not be cloned."
The package's wiki mentions this in the limitations section, to call "reset" before changing any configuration.
Update: This is due to the fact that the iframe becomes a cross-origin frame when bootstrapped/embeded, so it cannot be modified or serialized.
https://github.com/microsoft/PowerBI-JavaScript/wiki/Bootstrap-For-Better-Performance/33507b77a8c6f028ce9e0231ae27a97fd6f4866c