-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miscellaneous simple settings to the settings UI #17923
Conversation
@@ -1839,4 +1871,20 @@ | |||
<value>Non-monospace fonts:</value> | |||
<comment>This is a label that is followed by a list of proportional fonts.</comment> | |||
</data> | |||
<data name="Profile_RainbowSuggestions.Header" xml:space="preserve"> | |||
<value>Display suggestions UI preview text with rainbow formatting</value> | |||
<comment>This is a label for a setting that, when enabled, applies a rainbow coloring to the previewable text from the suggestions UI.</comment> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
0c7979c
to
c895a73
Compare
This comment was marked as resolved.
This comment was marked as resolved.
<!-- Enable Unfocused Acrylic --> | ||
<local:SettingContainer x:Uid="Globals_EnableUnfocusedAcrylic"> | ||
<ToggleSwitch IsOn="{x:Bind ViewModel.EnableUnfocusedAcrylic, Mode=TwoWay}" | ||
Style="{StaticResource ToggleSwitchInExpanderStyle}" /> | ||
</local:SettingContainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that this setting is compatibility.enableUnfocusedAcrylic
. Any ideas why it's in the compatibility namespace? To me, it makes sense to have in the appearance page, but the compatibility
namespace is making me second guess that it should be in the new compatibility page. Should we remove the compatibility
prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was more "OS compatibility" - unfocused acrylic is actually a different implementation of acrylic than usual. It has caused some issues in the past.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
c895a73
to
76b17f9
Compare
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
<comment>This is a label for a setting that, when enabled, applies a rainbow coloring to the preview text from the suggestions UI.</comment> | ||
</data> | ||
<data name="Globals_EnableColorSelection.Header" xml:space="preserve"> | ||
<value>Experimental: Add key bindings to color selected text</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<value>Experimental: Add key bindings to color selected text</value> | |
<value>Experimental: Add key bindings to highlight selected text and to search for and highlight all instances selected text</value> |
wording could use work, but more accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "Experimental: Add key bindings to highlight selected text and to search for and highlight all instances of selected text" (there was a missing "of")
I think that works. We can iterate on it if we get feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because of the SettingContainer styling. See inline comments below
<Style TargetType="local:SettingContainer">
<Setter Property="Margin" Value="0,4,0,0" />
<Setter Property="IsTabStop" Value="False" />
<Setter Property="MaxWidth" Value="1000" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="local:SettingContainer">
<Grid AutomationProperties.Name="{TemplateBinding Header}"
Style="{StaticResource NonExpanderGrid}">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="Auto" />
</Grid.ColumnDefinitions>
<!-- This StackPanel is the problem! I'm guessing the StackPanel makes it so that wrapping property
isn't applied because we _technically_ never wrap (even though wrap is set on the text block).
This doesn't occur with the HelpTextBlock below. Surprised this issue never came up for
localization! -->
<StackPanel Style="{StaticResource StackPanelInExpanderStyle}">
<StackPanel Orientation="Horizontal">
<TextBlock Style="{StaticResource SettingsPageItemHeaderStyle}"
Text="{TemplateBinding Header}" />
<Button x:Name="ResetButton"
Style="{StaticResource SettingContainerResetButtonStyle}">
<FontIcon Glyph=""
Style="{StaticResource SettingContainerFontIconStyle}" />
</Button>
</StackPanel>
<TextBlock x:Name="HelpTextBlock"
Style="{StaticResource SettingsPageItemDescriptionStyle}"
Text="{TemplateBinding HelpText}" />
</StackPanel>
<ContentPresenter Grid.Column="1"
HorizontalAlignment="Right"
VerticalAlignment="Center"
Content="{TemplateBinding Content}" />
</Grid>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's put experimental on the next line. or since it's a subtitle, Experimental Setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or explain the whole setting in there. Experimental: conhost-like Color Selection
Adds blah blah blah to blah blah and also blah blah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\ | ||
if (value >= 0.1 && value <= 10.0) \ | ||
{ \ | ||
str = fmt::format(FMT_STRING(L"{:.6g}"), value); \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lhecker why is this STRING
and not COMPILE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I blame Copilot haha. Changed to COMPILE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ಠ_ಠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't see this. FMT_STRING
used to be for doing compile-time checks but runtime formatting (compact assembly). Nowadays compile-time checks are always done.
Summary of the Pull Request
Adds the following settings to the settings UI:
Additionally, the following settings have graduated from experimental 🎓:
Part of #10000