Allow Github Copilot to be used with Terminal Chat

src/cascadia/QueryExtension/GithubCopilotLLMProvider.cpp

@@ -198,7 +198,7 @@ namespace winrt::Microsoft::Terminal::Query::Extension::implementation
                     Windows::Data::Json::JsonObject authValuesJson;
                     authValuesJson.SetNamedValue(accessTokenKey, WDJ::JsonValue::CreateStringValue(_authToken));
                     authValuesJson.SetNamedValue(refreshTokenKey, WDJ::JsonValue::CreateStringValue(_refreshToken));
-                    _AuthChangedHandlers(*this, winrt::make<GithubCopilotAuthenticationResult>(L"", authValuesJson.ToString()));
+                    _AuthChangedHandlers(*this, winrt::make<GithubCopilotAuthenticationResult>(winrt::hstring{}, authValuesJson.ToString()));
 
                     // we also need to get the correct endpoint to use and the username
                     _obtainUsernameAndRefreshTokensIfNeeded();
@@ -342,7 +342,7 @@ namespace winrt::Microsoft::Terminal::Query::Extension::implementation
             Windows::Data::Json::JsonObject authValuesJson;
             authValuesJson.SetNamedValue(accessTokenKey, WDJ::JsonValue::CreateStringValue(_authToken));
             authValuesJson.SetNamedValue(refreshTokenKey, WDJ::JsonValue::CreateStringValue(_refreshToken));
-            _AuthChangedHandlers(*this, winrt::make<GithubCopilotAuthenticationResult>(L"", authValuesJson.ToString()));
+            _AuthChangedHandlers(*this, winrt::make<GithubCopilotAuthenticationResult>(winrt::hstring{}, authValuesJson.ToString()));
         }
         CATCH_LOG();
     }

src/cascadia/QueryExtension/OpenAILLMProvider.cpp

@@ -130,6 +130,6 @@ namespace winrt::Microsoft::Terminal::Query::Extension::implementation
         responseMessageObject.Insert(L"content", WDJ::JsonValue::CreateStringValue(message));
         _jsonMessages.Append(responseMessageObject);
 
-        co_return winrt::make<OpenAIResponse>(message, errorType, L"");
+        co_return winrt::make<OpenAIResponse>(message, errorType, winrt::hstring{});
     }
 }

src/cascadia/TerminalSettingsEditor/AISettings.cpp

@@ -87,8 +87,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
     void AISettings::ClearAzureOpenAIKeyAndEndpoint_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)
     {
-        _ViewModel.AzureOpenAIEndpoint(L"");
-        _ViewModel.AzureOpenAIKey(L"");
+        _ViewModel.AzureOpenAIEndpoint(winrt::hstring{});
+        _ViewModel.AzureOpenAIKey(winrt::hstring{});
     }
 
     void AISettings::StoreAzureOpenAIKeyAndEndpoint_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)
@@ -98,8 +98,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         {
             _ViewModel.AzureOpenAIEndpoint(AzureOpenAIEndpointInputBox().Text());
             _ViewModel.AzureOpenAIKey(AzureOpenAIKeyInputBox().Password());
-            AzureOpenAIEndpointInputBox().Text(L"");
-            AzureOpenAIKeyInputBox().Password(L"");
+            AzureOpenAIEndpointInputBox().Text(winrt::hstring{});
+            AzureOpenAIKeyInputBox().Password(winrt::hstring{});
 
             TraceLoggingWrite(
                 g_hSettingsEditorProvider,
@@ -112,7 +112,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
     void AISettings::ClearOpenAIKey_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)
     {
-        _ViewModel.OpenAIKey(L"");
+        _ViewModel.OpenAIKey(winrt::hstring{});
     }
 
     void AISettings::StoreOpenAIKey_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)
@@ -121,7 +121,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         if (!password.empty())
         {
             _ViewModel.OpenAIKey(password);
-            OpenAIKeyInputBox().Password(L"");
+            OpenAIKeyInputBox().Password(winrt::hstring{});
 
             TraceLoggingWrite(
                 g_hSettingsEditorProvider,
@@ -134,7 +134,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
     void AISettings::ClearGithubCopilotTokens_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)
     {
-        _ViewModel.GithubCopilotAuthValues(L"");
+        _ViewModel.GithubCopilotAuthValues(winrt::hstring{});
     }
 
     void AISettings::SetAzureOpenAIActive_Check(const IInspectable& /*sender*/, const RoutedEventArgs& /*e*/)

src/cascadia/TerminalSettingsModel/AIConfig.cpp

@@ -162,7 +162,7 @@ winrt::hstring AIConfig::_RetrieveCredential(const wil::zwstring_view credential
     }
     catch (...)
     {
-        return L"";
+        return winrt::hstring{};
     }
 
     winrt::hstring password{ cred.Password() };