Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of responses from the AI #18220

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

Instead of manually parsing out code blocks from the response we receive, leverage the markdown to xaml parsing introduced in #17585

Validation Steps Performed

Responses are parsed as expected.

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@PankajBhojwani PankajBhojwani changed the title just in case Improve parsing of responses from the AI Nov 19, 2024
@PankajBhojwani
Copy link
Contributor Author

Screenshot for the new look (clicking the 'play' button sends the input to the shell):

image

Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 questions + what Dustin wrote.

src/cascadia/QueryExtension/ExtensionPalette.cpp Outdated Show resolved Hide resolved
OpenConsole.sln Outdated Show resolved Hide resolved
@DHowett DHowett merged commit 9ac902c into feature/llm Nov 25, 2024
20 checks passed
@DHowett DHowett deleted the dev/pabhoj/featurellm_misc_fixes branch November 25, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants