ColorFilter #66
Open
ColorFilter #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
requested changes
Oct 9, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
requested changes
Oct 15, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
tests/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.Tests.ps1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
ryfu-msft
requested changes
Oct 16, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
Comment on lines
+612
to
+613
| $colorFilterSetting = (Get-ItemProperty @FilterStatusArgs).Active | ||
| return ($colorFilterSetting -eq ([ColorFilter]::AccessibilityStatusValue)) |
There was a problem hiding this comment.
You get the property value for "Active" which is either 0 or 1, but you compare it with a string "colorfiltering".
| $FilterColorArgs = @{ Path = $global:ColorFilteringRegistryPath; Name = ([ColorFilter]::FilterColorProperty)} | ||
| if (-not(DoesRegistryKeyPropertyExist @FilterColorArgs)) | ||
| { | ||
| return $false |
There was a problem hiding this comment.
Shouldn't you be returning the enum value of the default filter rather than $false?
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
|
|
||
| if ($null -ne $this.HotkeyEnabled) | ||
| { | ||
| $KeyboardShortcutStatusArgs = @{ Path = $global:ColorFilteringRegistryPath; Name = ([ColorFilter]::HotkeyEnabledProperty); } |
There was a problem hiding this comment.
I would argue that in this scenario, creating a variable that you use once make it less readable. It makes sense in the Get() method above because you are reusing to check the existence of the key. But here it makes it more confusing and adds 2 unnecessary lines.
Set-ItemProperty -Path $global:ColorFilteringRegistryPath -Name [ColorFilter]::HotkeyEnabledProperty -Value $ColorFilterValue
Please fix this and the other areas that do this.
tests/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.Tests.ps1
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't complete, due to excessive PR approval volume, but the Get method is at least functional.