fix: fix object set in collector

midwayjs · Oct 25, 2018 · 1892456 · 1892456
1 parent b7ee0ed
commit 1892456
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/metrics/src/collect/CompactMetricsCollector.ts b/packages/metrics/src/collect/CompactMetricsCollector.ts
@@ -72,21 +72,21 @@ export class CompactMetricsCollector extends MetricsCollector {
     let totalCount = new BigNumber();
     let totalRt = new BigNumber();
     let successCount = new BigNumber();
-    let hitCount = new BigNumber(-1);
+    let hitCount = new BigNumber(-1, -1);
 
     let countPerCategory = fastCompass.getMethodCountPerCategory(start);
     for (let [ key, value ] of countPerCategory.entries()) {
       if (value.has(start)) {
         this.addMetricWithSuffix(name, key + '_bucket_count', value.get(start).toString(), start,
           MetricObject.MetricType.DELTA, bucketInterval);
 
-        totalCount.add(value.get(start));
+        totalCount = totalCount.add(value.get(start));
         if ('success' === key) {
-          successCount.add(value.get(start));
+          successCount = successCount.add(value.get(start));
         }
         if ('hit' === key) {
           hitCount = value.get(start);
-          successCount.add(value.get(start));
+          successCount = successCount.add(value.get(start));
         }
       } else {
         this.addMetricWithSuffix(name, key + '_bucket_count', 0, start,
@@ -96,7 +96,7 @@ export class CompactMetricsCollector extends MetricsCollector {
 
     for (let value of fastCompass.getMethodRtPerCategory(start).values()) {
       if (value.has(start)) {
-        totalRt.add(value.get(start));
+        totalRt = totalRt.add(value.get(start));
       }
     }
     this.addMetricWithSuffix(name, 'bucket_count', totalCount.toString(), start,

diff --git a/packages/metrics/src/collect/NormalMetricsCollector.ts b/packages/metrics/src/collect/NormalMetricsCollector.ts
@@ -73,21 +73,21 @@ export class NormalMetricsCollector extends MetricsCollector {
     let totalCount = new BigNumber();
     let totalRt = new BigNumber();
     let successCount = new BigNumber();
-    let hitCount = new BigNumber(-1);
+    let hitCount = new BigNumber(-1, -1);
 
     let countPerCategory = fastCompass.getMethodCountPerCategory(start);
     for (let [ key, value ] of countPerCategory.entries()) {
       if (value.has(start)) {
         this.addMetricWithSuffix(name, key + '_bucket_count', value.get(start).toString(), start,
           MetricObject.MetricType.DELTA, bucketInterval);
 
-        totalCount.add(value.get(start));
+        totalCount = totalCount.add(value.get(start));
         if ('success' === key) {
-          successCount.add(value.get(start));
+          successCount = successCount.add(value.get(start));
         }
         if ('hit' === key) {
           hitCount = value.get(start);
-          successCount.add(value.get(start));
+          successCount = successCount.add(value.get(start));
         }
       } else {
         this.addMetricWithSuffix(name, key + '_bucket_count', 0, start,
@@ -97,7 +97,7 @@ export class NormalMetricsCollector extends MetricsCollector {
 
     for (let value of fastCompass.getMethodRtPerCategory(start).values()) {
       if (value.has(start)) {
-        totalRt.add(value.get(start));
+        totalRt = totalRt.add(value.get(start));
       }
     }
     this.addMetricWithSuffix(name, 'bucket_count', totalCount.toString(), start,