Handle more edge cases

miharekar · Dec 20, 2024 · 8805879 · 8805879
1 parent 718a22c
commit 8805879
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/app/models/parsers/base.rb b/app/models/parsers/base.rb
@@ -36,7 +36,7 @@ def self.parse_json(file, retrying: false)
         Appsignal.set_message("JSON parsing failed for #{s3_response.etag}")
         raise
       else
-        file = file.delete("\n")
+        file = file.gsub(/[\u0000-\u001F\u007F-\u009F]/, "")
         retrying = true
         retry
       end

diff --git a/test/files/invalid_profile_3.json b/test/files/invalid_profile_3.json
diff --git a/test/models/parsers/decent_json_test.rb b/test/models/parsers/decent_json_test.rb
@@ -98,6 +98,13 @@ def new_shot(path, user: @user)
       assert_equal 237, shot.information.timeframe.size
     end
 
+    test "handles even more even more invalid profile string" do
+      shot = new_shot("test/files/invalid_profile_3.json")
+      assert shot.valid?
+      assert_equal "Flow profile for milky drinks", shot.profile_title
+      assert_equal 105, shot.information.timeframe.size
+    end
+
     test "handles invalid settings" do
       shot = new_shot("test/files/invalid_settings.json")
       assert shot.valid?