Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred.getInvocationInfo.proceedToAfterExecSpinlocks error logging #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wulfsolter
Copy link
Contributor

@wulfsolter wulfsolter commented Nov 26, 2019

Inside a vanilla function() method (as opposed to async/promise etc) in a SailsJS service attempting to access the property of an undefined results in an error that has not triggered creation of an omen, so only getting logging of

5|WW-API | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
5|WW-API | WARNING: Something seems to be wrong with this function.
5|WW-API | It is trying to signal that it has finished AGAIN, after
5|WW-API | already resolving/rejecting once.
5|WW-API | (silently ignoring this...)
5|WW-API |  [?] For more help, visit https://sailsjs.com/support
5|WW-API | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

This PR extends how Deferred.getInvocationInfo.proceedToAfterExecSpinlocks handles passed params - to log out the original error even if no omen exists yet, and to also only log errCbArg if it actually exists.

@mikermcneil I should've done this originally in #6 :)

…rg regardless of having an omen, not print errCbArg if not present
@meetDeveloper
Copy link

@mikermcneil Can we please look at this, this is a problem with us also.

@mikermcneil mikermcneil requested review from eashaw and removed request for mikermcneil July 1, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants