[motherless] Initial support #6221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smackingpotato
force-pushed
the
master
branch
from
8dde9c7 to
611cb2b
Compare
|
Force pushing to change commit messages |
shelvacu
reviewed
Oct 22, 2024
There was a problem hiding this comment.
I believe this PR should include tests, see https://github.com/mikf/gallery-dl/tree/master/test/results
I'm not anywhere near an expert on gallery-dl, so please feel free to tell me I'm wrong and do it anyways. Keeping that in mind, I hope this is helpful.
- Add support for single images and videos - Tidy metadata extractors - Add gallery downloaders - Add support details - Update media count extractors
smackingpotato
force-pushed
the
master
branch
from
e035000 to
e2f53c6
Compare
smackingpotato
force-pushed
the
master
branch
from
e2f53c6 to
5547955
Compare
|
I've started work on the tests. This will include a few more tweaks to get the naming conventions to pass |
mikf
added a commit
that referenced
this pull request
Nov 22, 2024
|
So I went ahead and wrote some code myself: b78c35f I took some inspiration from the code in this PR, but there were just too many overall issues to "fix" it, so writing the code myself was the better option I thought. A proper code review would have taken even more time, so I skipped that as well ... sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for motherless.com, for
Also adds keywords for filenames, extracting metadata from pages. See
-Koutput.