Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.9 on Windows #6684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Starz0r
Copy link
Contributor

@Starz0r Starz0r commented Dec 17, 2024

Currently GitHub generates executables for Windows from Python 3.8, which has been EOL for more than 2 months now. This PR corrects it by building with Python 3.9 instead of an out of date Python.

@mikf
Copy link
Owner

mikf commented Dec 18, 2024

The windows_x86.exe executables are meant for backwards compatibility. I'd like to keep them usable on Windows 7 machines, so (regular) Python 3.8 is the highest this can go.

@Starz0r
Copy link
Contributor Author

Starz0r commented Dec 20, 2024

I don't think it's worth supporting a version of Windows that old. Even so, the current (Windows) binaries on GitHub are built with CPython 3.8, and there isn't a distinguished x86 or x64 build. Just a singular x64 build that uses CPython 3.8. Is it possible that we can get binaries that are built with CPython 3.9 support?

@mikf
Copy link
Owner

mikf commented Dec 20, 2024

The GitHub Actions workflow this PR is modifying is responsible for building and releasing "nightly" binaries at https://github.com/gdl-org/builds/releases

The stable releases from https://github.com/mikf/gallery-dl/releases are built on my own PC on a Windows 7 x86 VM and a Ubuntu 22.04 LTS VM as a part of running scripts/release.sh

@amayra
Copy link

amayra commented Dec 20, 2024

is there any benefit of upgrading Python that is used for building if you don't use any new features in the newest versions?

@mikf
Copy link
Owner

mikf commented Dec 20, 2024

CPython interpreters got faster / more efficient with each new version, especially Python 3.11. There are probably security related bug fixes that do not get ported to the EOL versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants