-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TikTok] Add support #6708
base: master
Are you sure you want to change the base?
[TikTok] Add support #6708
Conversation
Respond to comments Improve archiving and file naming
Before merging, I'd like to try supporting user profile scraping. I'll likely use I'll introduce a new I'll also think about supporting the download of profile pictures. Once I've completed this, or decided that it's out of the scope of this PR, I'd say it's ready for merging, barring any additional feedback 👍 |
In my limited experience, this doesn't mean that gallery-dl can't download the photo post (but this could mean that you can't download the audio)
vt.tiktok.com www.tiktok.com/t/
}, | ||
{ | ||
"#url" : "https://www.tiktok.com/@chillezy", | ||
"#comment" : "User profile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should admit that user profile extraction can be a tiny bit flakey. Very occasionally yt-dlp
will fail to extract user profile information and there's not a lot gallery-dl
can do about it. Is it okay to keep these tests in, or should they be skipped?
This PR adds support for TikTok slideshows.
List of supported URL formats:
/photo/
/video/
vm.tiktok.com
vt.tiktok.com
/t/
tiktok.com/@username
)I haven't performed extensive testing yet so there could well be edge cases that aren't covered by the extractor as it stands right now. I have tested with cookies, however, and I am able to extract photos from private accounts (as well as detect when cookies are required to extract photo URLs).
Closes:
#3061
#4177