Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unstable integration test caused by paramtable.GetNodeID #37908

Open
1 task done
weiliu1031 opened this issue Nov 21, 2024 · 1 comment
Open
1 task done

[Bug]: unstable integration test caused by paramtable.GetNodeID #37908

weiliu1031 opened this issue Nov 21, 2024 · 1 comment
Assignees
@weiliu1031
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@weiliu1031
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.4 and master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@weiliu1031 weiliu1031 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2024
@weiliu1031
Copy link
Contributor Author

/assign

This was referenced Nov 21, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 21, 2024
@weiliu1031
fix: unstable integration test caused by paramtable.GetNodeID (#37909)
5f3601a 
issue: #37908
cause paramtable is global single instance, which cause
paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 22, 2024
@weiliu1031
fix: unstable integration test caused by paramtable.GetNodeID (#37910)
e63a2f3 
issue: #37908
pr: #37909
cause paramtable is global single instance, which cause
paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

Signed-off-by: Wei Liu <[email protected]>
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 22, 2024
@yanliang567 yanliang567 removed their assignment Nov 22, 2024
JsDove pushed a commit to JsDove/milvus that referenced this issue Nov 26, 2024
@weiliu1031 @JsDove
fix: unstable integration test caused by paramtable.GetNodeID (milvus…
5bad56c 
…-io#37909)

issue: milvus-io#37908
cause paramtable is global single instance, which cause
paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliu1031 weiliu1031

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanliang567 @weiliu1031